feat: add zoom_extent_scale to Mapper.extent_from for Mid Zoom panel - #324
Merged
Conversation
Thread a new `zoom_extent_scale: float = 1.0` kwarg through Mapper.extent_from, plot_inversion_reconstruction, and plot_mapper. When >1.0, scales the brightness-derived extent by this factor about its centre and clamps the result so it never exceeds the source-plane mesh extent or sits arbitrarily close (capped at 0.7 × mesh half). Used by PyAutoLens's new Source Plane (Mid Zoom) subplot panel. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
zoom_extent_scaleparameter toMapper.extent_fromand threads it throughplot_inversion_reconstructionandplot_mapper. This lets callers (notably PyAutoLens's new "Source Plane (Mid Zoom)" subplot panel) request a source-plane view that's a multiple of the brightest-region extent, kept square and clamped so it never exceeds the source-plane mesh extent or sits arbitrarily close to it.API Changes
Mapper.extent_from(...)gains an optionalzoom_extent_scale: float = 1.0argument. Default behaviour is unchanged.plot_inversion_reconstruction(...)andplot_mapper(...)gain the same passthrough kwarg.zoom_extent_scale > 1.0, the returned extent is the brightest-region extent expanded by that factor about its centre, capped uniformly so (a) no edge exceeds the source-plane mesh extent (b) the half-width never exceeds 0.7 × the mesh half-width, keeping the panel a strict subset of the No Zoom view.See full details below.
Test Plan
python -m pytest test_autoarray/inversion/plot test_autoarray/inversion -xpassestest__plot_mapper__zoom_extent_scale__widens_extent_around_centreexercises the new kwargFull API Changes (for automation & release notes)
Added
Mapper.extent_from(values=None, zoom_to_brightest=True, zoom_percent=None, zoom_extent_scale=1.0)— new optional kwarg. Scales the brightness-derived extent by this factor about its centre, clamped to the mesh extent.plot_inversion_reconstruction(..., zoom_extent_scale=1.0, ...)— new optional kwarg, forwarded tomapper.extent_from.plot_mapper(..., zoom_extent_scale=1.0, ...)— new optional kwarg, forwarded toplot_inversion_reconstruction.Changed Behaviour
zoom_extent_scale=1.0(the default).zoom_extent_scale != 1.0, the returned extent is the brightest-region extent scaled by that factor about its centre, then capped to a half-width that is the smallest of: target half-width, distance from brightest centre to the nearest mesh edge, and 0.7 × the mesh half-width.🤖 Generated with Claude Code