skills#276
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR touches on skill data exports.
Fixed an issue where the gem description was outputting line breaks, which were causing issues with the wiki syntax.
A
max_levelparameter is now exported with the skill data. This indicates the maximum ordinal value in skill levels for determining how to display skill value ranges. I.e., 1 to maximum level.Tried to add better handling for skill icons. The icons should now export with the proper names that we want to use on the wiki. Additionally, skill data for transfigured gems and similar variants will export a
skill_iconparameter if the icon is the same as the base version of the skill. This should reduce a little bit of maintenance overhead when new transfigured gems are added to the game.We will no longer bother with trying to export projectile speed with the skill data. It has to be manually mapped, which requires a lot of effort, and at the end of the day it outputs a meaningless speed value that isn't useful for readers of the wiki.