fix: don't inflate/decompress if compressionThreshold is negative#1373
Closed
cxvqo wants to merge 1 commit intoPrismarineJS:masterfrom
Closed
fix: don't inflate/decompress if compressionThreshold is negative#1373cxvqo wants to merge 1 commit intoPrismarineJS:masterfrom
cxvqo wants to merge 1 commit intoPrismarineJS:masterfrom
Conversation
If compression is enabled, all following packets are encoded in the compressed packet format. Negative values will disable compression, meaning the packet format should remain in the uncompressed packet format. However, this packet is entirely optional, and if not sent, compression will also not be enabled (the notchian server does not send the packet when compression is disabled).
Member
|
Is this the case on all versions 1.8+? |
Author
|
yes |
Member
|
Why close? |
Author
Issue with my implementation of it. (I think) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follows the notchian client better as if the compressionThreshold is negative, it means that the packets are uncompressed, and it should treat them accordingly