Skip to content

Feat/convnet#1886

Open
SamKG wants to merge 8 commits into
PrincetonUniversity:develfrom
SamKG:feat/convnet
Open

Feat/convnet#1886
SamKG wants to merge 8 commits into
PrincetonUniversity:develfrom
SamKG:feat/convnet

Conversation

@SamKG

@SamKG SamKG commented Jan 19, 2021

Copy link
Copy Markdown
Collaborator

No description provided.

@lgtm-com

lgtm-com Bot commented Jan 19, 2021

Copy link
Copy Markdown
Contributor

This pull request introduces 1 alert and fixes 2 when merging 1f80b25 into dc42999 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 2 for Unused local variable

@SamKG SamKG requested a review from jvesely January 19, 2021 23:53
@lgtm-com

lgtm-com Bot commented Jan 20, 2021

Copy link
Copy Markdown
Contributor

This pull request introduces 1 alert and fixes 2 when merging 24f6c2b into 76b754f - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 2 for Unused local variable

jvesely
jvesely requested changes Jan 21, 2021
View reviewed changes

@jvesely jvesely left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few style nits and clarifications.

Comment thread psyneulink/library/compositions/compiledoptimizer.py Outdated
Comment thread psyneulink/library/compositions/compiledoptimizer.py Outdated
Comment thread psyneulink/library/compositions/pytorchcomponents.py Outdated
Comment thread psyneulink/library/compositions/pytorchcomponents.py Outdated
Comment thread psyneulink/library/compositions/pytorchcomponents.py
Comment thread psyneulink/library/compositions/pytorchmodelcreator.py Outdated
Comment thread psyneulink/library/compositions/pytorchcomponents.py Outdated
Comment thread psyneulink/library/compositions/pytorchcomponents.py
@lgtm-com

lgtm-com Bot commented Jan 26, 2021

Copy link
Copy Markdown
Contributor

This pull request fixes 2 alerts when merging 137aac9 into d9a5552 - view on LGTM.com

fixed alerts:

  • 2 for Unused local variable

jvesely
jvesely reviewed Jan 27, 2021
View reviewed changes
Comment thread tests/functions/test_transfer.py Outdated
@SamKG SamKG force-pushed the feat/convnet branch 2 times, most recently from 600edc2 to 4145f9d Compare February 2, 2021 14:24
@lgtm-com

lgtm-com Bot commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

This pull request fixes 2 alerts when merging 4145f9d into ab56672 - view on LGTM.com

fixed alerts:

  • 2 for Unused local variable

@SamKG

SamKG commented Feb 2, 2021

Copy link
Copy Markdown
Collaborator Author

retest this please

@SamKG SamKG requested a review from jvesely February 2, 2021 17:41
@lgtm-com

lgtm-com Bot commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

This pull request fixes 2 alerts when merging ce99cfd into ab56672 - view on LGTM.com

fixed alerts:

  • 2 for Unused local variable

jvesely
jvesely requested changes Feb 16, 2021
View reviewed changes

@jvesely jvesely left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit and a test fix otherwise looks good

Comment thread psyneulink/core/compositions/composition.py Outdated
Comment thread tests/functions/test_transfer.py Outdated
@lgtm-com

lgtm-com Bot commented Feb 28, 2021

Copy link
Copy Markdown
Contributor

This pull request fixes 2 alerts when merging 32167e2 into bc80aaf - view on LGTM.com

fixed alerts:

  • 2 for Unused local variable

@SamKG

SamKG commented Feb 28, 2021

Copy link
Copy Markdown
Collaborator Author

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvesely jvesely jvesely requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SamKG @jvesely