fix(ui): keep pause form description visible#22485
Open
Bortlesboat wants to merge 2 commits into
Open
Conversation
Bortlesboat
requested review from
chrisguidry,
cicdw,
desertaxle and
zzstoatzz
as code owners
July 12, 2026 23:29
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4b822fd26
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
desertaxle
requested changes
Jul 15, 2026
| <LazySchemaForm | ||
| schema={schema} | ||
| values={values} | ||
| onValuesChange={setValues} |
Member
There was a problem hiding this comment.
Could we make the description area shrink on shorter viewports? With a long description it pushes the form and the Resume/Cancel buttons below the screen. I think we should preserve the separate scrolling behavior while ensuring the footer always stays accessible, ideally with a small-viewport test to cover it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #21491
This PR keeps pause/resume input guidance visible while long schema forms scroll.
Details
The markdown description and schema form currently share one
overflow-y-autocontainer. With enough fields, scrolling the form also removes validation context such as "One or more of your inputs were invalid" from view.The description is now a non-shrinking sibling above the scroll region, and only the schema form scrolls. Dialog headers, footers, schema behavior, and API behavior are unchanged.
The existing ten-field regression now asserts both sides of the layout contract: the description is outside the scroll container and the final field remains inside it.
Verification:
npm test -- resume-flow-run-dialog.test.tsx --run(9 passed)npm run buildgit diff --checkThe local Node version was 24.14.0 versus the package's declared Node 22 range; tests and the full production build still completed successfully.