Skip to content

fix(ui): keep pause form description visible#22485

Open
Bortlesboat wants to merge 2 commits into
PrefectHQ:mainfrom
Bortlesboat:fix/pause-form-description
Open

fix(ui): keep pause form description visible#22485
Bortlesboat wants to merge 2 commits into
PrefectHQ:mainfrom
Bortlesboat:fix/pause-form-description

Conversation

@Bortlesboat

Copy link
Copy Markdown

closes #21491

This PR keeps pause/resume input guidance visible while long schema forms scroll.

Details

The markdown description and schema form currently share one overflow-y-auto container. With enough fields, scrolling the form also removes validation context such as "One or more of your inputs were invalid" from view.

The description is now a non-shrinking sibling above the scroll region, and only the schema form scrolls. Dialog headers, footers, schema behavior, and API behavior are unchanged.

The existing ten-field regression now asserts both sides of the layout contract: the description is outside the scroll container and the final field remains inside it.

Verification:

  • npm test -- resume-flow-run-dialog.test.tsx --run (9 passed)
  • Biome check on both touched files
  • ESLint on both touched files
  • npm run build
  • git diff --check

The local Node version was 24.14.0 versus the package's declared Node 22 range; tests and the full production build still completed successfully.

@github-actions github-actions Bot added bug Something isn't working ui Related to the Prefect web interface ui-replatform Related to the React UI rewrite labels Jul 12, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a4b822fd26

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui-v2/src/components/flow-runs/flow-run-actions/resume-flow-run-dialog.tsx Outdated
<LazySchemaForm
schema={schema}
values={values}
onValuesChange={setValues}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make the description area shrink on shorter viewports? With a long description it pushes the form and the Resume/Cancel buttons below the screen. I think we should preserve the separate scrolling behavior while ensuring the footer always stays accessible, ideally with a small-viewport test to cover it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ui Related to the Prefect web interface ui-replatform Related to the React UI rewrite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown description can be hidden on pause_flow_run input box

2 participants