Fix hover-only hotkey list; add reusable cheat-sheet (findability fix, part 2) - #122
Closed
alpha5611331 wants to merge 1 commit into
Closed
Fix hover-only hotkey list; add reusable cheat-sheet (findability fix, part 2)#122alpha5611331 wants to merge 1 commit into
alpha5611331 wants to merge 1 commit into
Conversation
…only status-panel.tsx's "Show Hotkeys" control only ever revealed the list on hover - nothing visible without pointing at it first, the exact antipattern the rest of the control bar has. Converts it to a proper dialog opened by click or a new '?' shortcut (local to this window, not a registered global hotkey - it only needs focus, not stealth-mode reach). Extracts the hotkey list itself into hotkey-cheatsheet.tsx so status-panel.tsx and documentation-dialog.tsx render the same data instead of two independently-drifting copies.
Member
Author
|
Superseded — consolidated into #121 as a single PR per updated scope (one PR resolving the UI/UX findability issue completely, for manual review). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of the same findability investigation as #121.
status-panel.tsxalready had a "Show Hotkeys" control - but it only revealed the list on hover, so nothing was visible without pointing at it first. That's the exact antipattern found across the rest of the app (icon-only control bar, hidden hotkeys with no on-screen affordance): the team had already reached for a fix here and landed on the same failure mode.Separately, the hotkey list itself was duplicated between
status-panel.tsxanddocumentation-dialog.tsxwith two different renderings, which is how they could drift.What changed
src/renderer/components/custom/hotkey-cheatsheet.tsx(new) — the grouped hotkey list, extracted once. ExportsHotkeyCheatsheet(content) andHotkeyCheatsheetDialog(dialog wrapper).status-panel.tsx— "Show Hotkeys" is now a real button that opensHotkeyCheatsheetDialogon click, plus a new?shortcut (renderer-localkeydownlistener, guarded against firing while typing in a field - not a registered global hotkey, since this only needs to work while the window has focus, unlike the stealth-mode-reaching ones inlib/hotkeys.ts).documentation-dialog.tsx— its "Hotkeys" accordion section now renders the same sharedHotkeyCheatsheetinstead of its own independent copy.Notes
?shortcut.docs/ux-conventions.md's command-palette status note could optionally mention that the T3 cheat-sheet requirement is now satisfied - not included here since that file doesn't exist onmainyet.Test plan
pnpm lintclean on changed/new filestsc -bcleanvitedev server - all three files compile/transform without error?on/main, confirm the Documentation dialog's Hotkeys section still renders correctly