Skip to content

rec and dnsdist: Move to yaml_serde - #17958

Merged
omoerbeek merged 1 commit into
PowerDNS:masterfrom
omoerbeek:yaml-serde
Aug 27, 2026
Merged

rec and dnsdist: Move to yaml_serde#17958
omoerbeek merged 1 commit into
PowerDNS:masterfrom
omoerbeek:yaml-serde

Conversation

@omoerbeek

Copy link
Copy Markdown
Member

Short description

See #17710, no more dependency on a deprecated and an unsafe crate with this drop-in replacement.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
@omoerbeek omoerbeek added rec dnsdist rust Pull requests that update Rust code labels Aug 27, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 33054850355

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.007%) to 71.183%

Details

  • Coverage increased (+0.007%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 58 coverage regressions across 13 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

58 previously-covered lines in 13 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
pdns/recursordist/rec-system-resolve.cc 19 49.32%
pdns/recursordist/test-syncres_cc1.cc 11 80.03%
pdns/dnsdistdist/dnsdist-tcp.cc 5 74.46%
pdns/packethandler.cc 4 69.03%
pdns/iputils.cc 3 61.32%
pdns/rcpgenerator.cc 3 89.44%
pdns/remote_logger.cc 3 56.8%
modules/godbcbackend/sodbc.cc 2 69.31%
modules/lmdbbackend/lmdbbackend.cc 2 72.32%
pdns/recursordist/recpacketcache.cc 2 82.35%

Coverage Stats

Coverage Status
Relevant Lines: 173431
Covered Lines: 135364
Line Coverage: 78.05%
Relevant Branches: 82910
Covered Branches: 47106
Branch Coverage: 56.82%
Branches in Coverage %: Yes
Coverage Strength: 6038848.65 hits per line

💛 - Coveralls

@rgacogne rgacogne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@omoerbeek
omoerbeek merged commit 2db5fde into PowerDNS:master Aug 27, 2026
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dnsdist rec rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants