Skip to content

auth: finer TSIG key deletion - #17766

Open
miodvallat wants to merge 2 commits into
PowerDNS:masterfrom
miodvallat:rmrmrm
Open

auth: finer TSIG key deletion#17766
miodvallat wants to merge 2 commits into
PowerDNS:masterfrom
miodvallat:rmrmrm

Conversation

@miodvallat

@miodvallat miodvallat commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Short description

This PR adds the ability to specifiy an algorithm, in addition to a name, when performing a TSIG key deletion.
For SQL backends, this relies upon an extra query.

Will fix #1466.

Note that, before this PR, the API would not let you have multiple TSIG keys with the same name, but different algorithms, while pdnsutil wouldn't mind. This restriction is lifted as part of these changes.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls

coveralls commented Jul 22, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 32940036953

Coverage increased (+4.1%) to 71.232%

Details

  • Coverage increased (+4.1%) from the base build.
  • Patch coverage: 26 uncovered changes across 5 files (41 of 67 lines covered, 61.19%).
  • 24 coverage regressions across 7 files.

Uncovered Changes

File Changed Covered %
modules/remotebackend/remotebackend.cc 12 0 0.0%
modules/bindbackend/binddnssec.cc 8 2 25.0%
pdns/ws-auth.cc 18 14 77.78%
modules/remotebackend/httpconnector.cc 3 0 0.0%
pdns/dnsbackend.hh 1 0 0.0%
Total (12 files) 67 41 61.19%

Coverage Regressions

24 previously-covered lines in 7 files lost coverage.

File Lines Losing Coverage Coverage
pdns/recursordist/test-syncres_cc1.cc 5 80.2%
pdns/signingpipe.cc 5 83.68%
pdns/dnsdistdist/dnsdist-concurrent-connections.cc 4 90.13%
pdns/recursordist/test-syncres_cc2.cc 3 79.35%
pdns/tsigverifier.cc 3 77.22%
pdns/misc.cc 2 62.54%
pdns/ws-auth.cc 2 80.85%

Coverage Stats

Coverage Status
Relevant Lines: 173392
Covered Lines: 135392
Line Coverage: 78.08%
Relevant Branches: 82922
Covered Branches: 47186
Branch Coverage: 56.9%
Branches in Coverage %: Yes
Coverage Strength: 6734587.31 hits per line

💛 - Coveralls

@miodvallat
miodvallat force-pushed the rmrmrm branch 3 times, most recently from ac2adfc to 4d7fcac Compare July 24, 2026 06:45
@miodvallat
miodvallat marked this pull request as ready for review July 24, 2026 06:46
@miodvallat
miodvallat force-pushed the rmrmrm branch 3 times, most recently from d9ceda3 to 406c6c5 Compare July 24, 2026 07:07

@Habbie Habbie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few notes. Shape looks right. Will finish review when the pdnsutil bug is fixed

Comment thread pdns/pdnsutil.cc Outdated
Comment thread pdns/pdnsutil.cc Outdated
Comment thread pdns/ws-auth.cc
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide delete-tsig-key name algo

3 participants