auth: finer TSIG key deletion - #17766
Open
miodvallat wants to merge 2 commits into
Open
Conversation
Coverage Report for CI Build 32940036953Coverage increased (+4.1%) to 71.232%Details
Uncovered Changes
Coverage Regressions24 previously-covered lines in 7 files lost coverage.
Coverage Stats💛 - Coveralls |
miodvallat
force-pushed
the
rmrmrm
branch
3 times, most recently
from
July 24, 2026 06:45
ac2adfc to
4d7fcac
Compare
miodvallat
marked this pull request as ready for review
July 24, 2026 06:46
miodvallat
force-pushed
the
rmrmrm
branch
3 times, most recently
from
July 24, 2026 07:07
d9ceda3 to
406c6c5
Compare
Habbie
requested changes
Aug 25, 2026
Habbie
left a comment
Member
There was a problem hiding this comment.
few notes. Shape looks right. Will finish review when the pdnsutil bug is fixed
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the ability to specifiy an algorithm, in addition to a name, when performing a TSIG key deletion.
For SQL backends, this relies upon an extra query.
Will fix #1466.
Note that, before this PR, the API would not let you have multiple TSIG keys with the same name, but different algorithms, while
pdnsutilwouldn't mind. This restriction is lifted as part of these changes.Checklist
I have: