Server config improvements#2650
Open
ljeub-pometry wants to merge 12 commits into
Open
Conversation
…ks and add more open telemetry options
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 2afe339 | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
4 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
4 ns/iter (± 0) |
1 ns/iter (± 0) |
4 |
lotr_graph/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
8741167 ns/iter (± 235253) |
1564816 ns/iter (± 35303) |
5.59 |
lotr_graph_window_100/num_nodes |
14 ns/iter (± 0) |
5 ns/iter (± 0) |
2.80 |
lotr_graph_window_100_materialise/materialize |
8531891 ns/iter (± 151671) |
1669150 ns/iter (± 10700) |
5.11 |
lotr_graph_window_10/has_node_existing |
143 ns/iter (± 12) |
62 ns/iter (± 11) |
2.31 |
lotr_graph_window_10_materialise/materialize |
3459326 ns/iter (± 99457) |
971980 ns/iter (± 4278) |
3.56 |
lotr_graph_subgraph_10pc/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_subgraph_10pc_materialise/materialize |
2089009 ns/iter (± 106245) |
334634 ns/iter (± 1287) |
6.24 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
147 ns/iter (± 9) |
62 ns/iter (± 14) |
2.37 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1249880 ns/iter (± 49456) |
230399 ns/iter (± 2617) |
5.42 |
lotr_graph_window_50_layered/num_edges_temporal |
151261 ns/iter (± 5323) |
70121 ns/iter (± 7586) |
2.16 |
lotr_graph_window_50_layered/has_node_existing |
401 ns/iter (± 25) |
129 ns/iter (± 12) |
3.11 |
lotr_graph_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_window_50_layered/graph_latest |
91883 ns/iter (± 2037) |
36649 ns/iter (± 916) |
2.51 |
lotr_graph_window_50_layered_materialise/materialize |
31691642 ns/iter (± 226830) |
3488825 ns/iter (± 24948) |
9.08 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
654389 ns/iter (± 10272) |
192686 ns/iter (± 1569) |
3.40 |
lotr_graph_persistent_window_50_layered/has_node_existing |
454 ns/iter (± 406) |
174 ns/iter (± 83) |
2.61 |
lotr_graph_persistent_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_persistent_window_50_layered/iterate_exploded_edges |
3609491 ns/iter (± 56701) |
1659940 ns/iter (± 19402) |
2.17 |
lotr_graph_persistent_window_50_layered/graph_latest |
138854 ns/iter (± 6156) |
57549 ns/iter (± 4809) |
2.41 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
55420983 ns/iter (± 1088662) |
5298035 ns/iter (± 147912) |
10.46 |
This comment was automatically generated by workflow using github-action-benchmark.
…adding a certificate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
GraphServer()in python now takes the config parameters as a dict such that it can reuse the same parsing code as loading config from file. One less place to miss when adding new config parametersWhy are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?