Remove CheckComposableSql() override#2035
Open
yykkibbb wants to merge 1 commit intoPomeloFoundation:mainfrom
Open
Remove CheckComposableSql() override#2035yykkibbb wants to merge 1 commit intoPomeloFoundation:mainfrom
yykkibbb wants to merge 1 commit intoPomeloFoundation:mainfrom
Conversation
The upstream issue (dotnet/efcore#26471) was resolved in EF Core 7.0.0. The base QuerySqlGenerator.CheckComposableSqlTrimmed now recognizes both SELECT and WITH as composable SQL, so the Pomelo override is no longer needed. Also remove the stored procedure test method overrides in FromSqlSprocQueryMySqlTest that expected MySqlException, since the base class tests already expect InvalidOperationException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckComposableSql()override inMySqlQuerySqlGenerator.cs, which was introduced to support CTE (WITH) expressions in raw SQLQuerySqlGenerator.CheckComposableSqlTrimmednow natively recognizes bothSELECTandWITHas composable SQLFromSqlSprocQueryMySqlTest.csthat expectedMySqlException. The base class tests already expectInvalidOperationException, which is now the correct behavior since non-composable SQL (e.g.,CALL) is rejected by the base class before reaching the databaseFixes #1543
Test plan
FromSqlSprocQueryMySqlTest— 327 tests passed (base class tests now correctly expectInvalidOperationException)FromSqlQueryMySqlTest— CTE composition tests continue to passSqlQueryMySqlTest— CTE composition tests continue to pass