Skip to content

Support for EF Core 10 and test fixes (MySQL 8+, ReadOnlySpan, collation)#2032

Open
omarbaruzzo wants to merge 1 commit intoPomeloFoundation:mainfrom
omarbaruzzo:main
Open

Support for EF Core 10 and test fixes (MySQL 8+, ReadOnlySpan, collation)#2032
omarbaruzzo wants to merge 1 commit intoPomeloFoundation:mainfrom
omarbaruzzo:main

Conversation

@omarbaruzzo
Copy link

Summary

This PR updates the solution for EF Core 10 compatibility and fixes several functional test failures encountered with current dependencies and MySQL 8+.

Changes

Library

  • MySqlQuerySqlGenerator: for single-argument aggregate functions (AVG, SUM, MIN, MAX, etc.), generate Name(arg) instead of calling base, to preserve the previous SQL shape and avoid breaking changes for users when EF Core 9.x started generating Name((arg)).

Tests

  • ReadOnlySpan / expression tree: replaced local arrays with List<T> in query tests where Contains() was used, so that the expression tree uses Enumerable.Contains instead of span-based overloads and the interpreter no longer fails (e.g. EscapesMySqlTestBase, GearsOfWarQueryMySqlTest, TPCGearsOfWarQueryMySqlTest, TPTGearsOfWarQueryMySqlTest).
  • Migrations: added [SupportedServerVersionCondition(DefaultExpression, AlternativeDefaultExpression)] to tests that add primitive collection columns with default values, so they are skipped on MySQL 5.7 where those defaults are not supported.
  • README (IntegrationTests, FunctionalTests): added a note that tests are intended to be run against MySQL 8.0+ or equivalent MariaDB.

Testing

  • Build and unit tests: OK
  • Integration tests: OK (with migrations and MySQL 8+)
  • Functional tests: OK (with MySQL 8+ and unicode_ci database where applicable)

Notes

  • Database for functional tests is expected to be MySQL 8.0+ (or equivalent MariaDB); some tests are skipped on older servers via version conditions.

Omar Baruzzo

@jackieevans3935
Copy link

@lauxjpn When is this PR going to be reviewed? Its been sitting for 2 weeks and has no response from you. We need to migrate to EF Core 10 and looking at weeks worth of work to migrate to Oracle's EF implementation.

@roji
Copy link

roji commented Mar 3, 2026

@jackieevans3935 this is an open source, volunteer-based project - as far as I know you're not paying the maintainers. So I'd at least tone down my language.

@jackieevans3935
Copy link

jackieevans3935 commented Mar 3, 2026

Fair point, I sponsored this project now to help give this migration the needed financial support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants