Support for EF Core 10 and test fixes (MySQL 8+, ReadOnlySpan, collation)#2032
Open
omarbaruzzo wants to merge 1 commit intoPomeloFoundation:mainfrom
Open
Support for EF Core 10 and test fixes (MySQL 8+, ReadOnlySpan, collation)#2032omarbaruzzo wants to merge 1 commit intoPomeloFoundation:mainfrom
omarbaruzzo wants to merge 1 commit intoPomeloFoundation:mainfrom
Conversation
|
@lauxjpn When is this PR going to be reviewed? Its been sitting for 2 weeks and has no response from you. We need to migrate to EF Core 10 and looking at weeks worth of work to migrate to Oracle's EF implementation. |
|
@jackieevans3935 this is an open source, volunteer-based project - as far as I know you're not paying the maintainers. So I'd at least tone down my language. |
|
Fair point, I sponsored this project now to help give this migration the needed financial support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the solution for EF Core 10 compatibility and fixes several functional test failures encountered with current dependencies and MySQL 8+.
Changes
Library
Name(arg)instead of calling base, to preserve the previous SQL shape and avoid breaking changes for users when EF Core 9.x started generatingName((arg)).Tests
List<T>in query tests whereContains()was used, so that the expression tree usesEnumerable.Containsinstead of span-based overloads and the interpreter no longer fails (e.g.EscapesMySqlTestBase,GearsOfWarQueryMySqlTest,TPCGearsOfWarQueryMySqlTest,TPTGearsOfWarQueryMySqlTest).[SupportedServerVersionCondition(DefaultExpression, AlternativeDefaultExpression)]to tests that add primitive collection columns with default values, so they are skipped on MySQL 5.7 where those defaults are not supported.Testing
Notes
Omar Baruzzo