Skip to content

Fix build with Boost 1.89.0#6330

Merged
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
cho-m:boost-1.89.0
Aug 28, 2025
Merged

Fix build with Boost 1.89.0#6330
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
cho-m:boost-1.89.0

Conversation

@cho-m
Copy link
Contributor

@cho-m cho-m commented Aug 27, 2025

This fixes a regression in 0404f7c / 1.15.1 as Boost::system is not valid since Boost 1.89.0.

PCL requires a minimum of Boost 1.71.0 so Boost.System is guaranteed to be header-only (since 1.691) and the component can be removed.


Build failure was originally seen at Homebrew (Homebrew/homebrew-core#235073) when trying to update to 1.15.1

  -- Configuring done (32.4s)
  CMake Error at outofcore/CMakeLists.txt:79 (target_link_libraries):
    Target "pcl_outofcore" links to:
  
      Boost::system
  
    but the target was not found.  Possible reasons include:
  
      * There is a typo in the target name.
      * A find_package call is missing for an IMPORTED target.
      * An ALIAS target is missing.

Footnotes

  1. https://www.boost.org/doc/libs/1_69_0/libs/system/doc/html/system.html#changes_in_boost_1_69

This fixes a regression in 0404f7c
/ 1.15.1 as `Boost::system` is not valid since Boost 1.89.0.

PCL requires a minimum of Boost 1.71.0 so Boost.System is guaranteed to
be header-only (since 1.69[^1]) and the component can be removed.

[^1]: https://www.boost.org/doc/libs/1_69_0/libs/system/doc/html/system.html#changes_in_boost_1_69
Copy link
Contributor

@larshg larshg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shame it wasn't tested with the pre-release so it could have been fixed before 1.15.1 was released 😢

But thanks for the PR 😄

@mvieth mvieth added module: cmake changelog: fix Meta-information for changelog generation labels Aug 28, 2025
@mvieth
Copy link
Member

mvieth commented Aug 28, 2025

A shame it wasn't tested with the pre-release so it could have been fixed before 1.15.1 was released 😢

I actually did test the 1.15.1 release candidate with Boost 1.89.0, but it was our last-minute change in #6325 that broke compatibility with Boost 1.89.0 (more specifically, changing ${Boost_SYSTEM_LIBRARY} to Boost::system).

Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @cho-m

@mvieth mvieth merged commit 9933344 into PointCloudLibrary:master Aug 28, 2025
13 checks passed
@larshg
Copy link
Contributor

larshg commented Aug 28, 2025

A shame it wasn't tested with the pre-release so it could have been fixed before 1.15.1 was released 😢

I actually did test the 1.15.1 release candidate with Boost 1.89.0, but it was our last-minute change in #6325 that broke compatibility with Boost 1.89.0 (more specifically, changing ${Boost_SYSTEM_LIBRARY} to Boost::system).

Ahh, yeah okay. That was unfortunate - somehow I remembered it as it was part of the release candidate 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: fix Meta-information for changelog generation module: cmake

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants