Cleanup gpu fpfh and remove unnecessary headers#6311
Cleanup gpu fpfh and remove unnecessary headers#6311larshg merged 2 commits intoPointCloudLibrary:masterfrom
Conversation
| #ifndef M_PI | ||
| #define M_PI 3.14159265358979323846f | ||
| #endif |
There was a problem hiding this comment.
M_PI is used in this file further down, and I assume there is a reason why these lines have been added in the past, so I would rather keep them. Or is there a reason why you removed them? Did they cause any problem for you?
There was a problem hiding this comment.
Seems to be required on windows - alternatively we could include #include <pcl/pcl_macros.h> as it has the definition as well. Same for vfh.cu.
There was a problem hiding this comment.
Yeah, and gpu aren't build on windows CI, so we have to verify explicitly.
There was a problem hiding this comment.
I think there have been problems when including pcl_macros.h in a .cu file? I would rather just keep these three lines.
There was a problem hiding this comment.
You are right. I originally removed this because I saw that PI was defined in internal.hpp which was being included, but I didn't notice M_PI was named different. On my machine this works because it is using the definition in /usr/include/math.h, which probably won't work on windows. Should I put it back in or switch the use of M_PI to PI defined in internal.hpp?
There was a problem hiding this comment.
I would prefer putting the three lines back
3 participants
This cleans up some unnecessary headers.
This was tested on Ubuntu 24.04, successfully building and running.