Re-add instantiation of Convolution for MSVC#6310
Merged
mvieth merged 1 commit intoPointCloudLibrary:masterfrom Jul 17, 2025
Merged
Re-add instantiation of Convolution for MSVC#6310mvieth merged 1 commit intoPointCloudLibrary:masterfrom
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
Conversation
Partially reverting PointCloudLibrary@1092d70 With MSVC, building the app pcl_convolve fails for static builds without these instantiations. With gcc and clang, these instantiations do not seem to be necessary, and with gcc they even produce a warning when building with default-hidden-visibility. So we only do the explicit instantiations when compiling with MSVC.
mvieth
added
module: filters
changelog: fix
larshg
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially reverting 1092d70
With MSVC, building the app pcl_convolve fails for static builds without these instantiations. With gcc and clang, these instantiations do not seem to be necessary, and with gcc they even produce a warning when building with default-hidden-visibility. So we only do the explicit instantiations when compiling with MSVC.
See also https://github.com/microsoft/vcpkg/pull/46378/files#diff-5fe93e814fe39547c696f5fbeabd7a655bf6d33e9be3a9a551a6114c8d6aee14
and 1092d70#r162020986