Fix get the root directory path of Boost#6259
Merged
mvieth merged 1 commit intoPointCloudLibrary:masterfrom Apr 1, 2025
Merged
Fix get the root directory path of Boost#6259mvieth merged 1 commit intoPointCloudLibrary:masterfrom
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
Conversation
In this commit, replace the method to get the root directory path based on Boost_DIR, because Boost_INCLUDE_DIR is empty.
mvieth
approved these changes
Mar 31, 2025
Member
mvieth
left a comment
mvieth
left a comment
There was a problem hiding this comment.
Looks good to me.
Note
I had no idea the GitHub markdown permits doing a note like this 😆
mvieth
added
module: cmake
changelog: fix
larshg
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, replace the method to get the root directory path based on Boost_DIR, because Boost_INCLUDE_DIR is empty now.
Note
This change is necessary to generate the PCL All-in-one Installer correctly. But, this change have nothing to do with many developers.