Skip to content

Fix perception_pcl_ros dockerfile for release pipeline#6233

Merged
mvieth merged 2 commits intoPointCloudLibrary:masterfrom
mvieth:fix_perception_pcl_ros_docker
Feb 7, 2025
Merged

Fix perception_pcl_ros dockerfile for release pipeline#6233
mvieth merged 2 commits intoPointCloudLibrary:masterfrom
mvieth:fix_perception_pcl_ros_docker

Conversation

@mvieth
Copy link
Member

@mvieth mvieth commented Feb 6, 2025

Ros noetic is the last ROS 1 release that is still supported (but only until May this year)
Needs to be fixed so that release pipeline can finish successfully: https://dev.azure.com/PointCloudLibrary/pcl/_build/results?buildId=25053&view=results

Ros noetic is the last ROS 1 release that is still supported (but only until May this year)
@mvieth mvieth added the changelog: fix Meta-information for changelog generation label Feb 6, 2025
@mvieth mvieth requested a review from larshg February 6, 2025 17:37
@larshg
Copy link
Contributor

larshg commented Feb 6, 2025

Seems to be referenced old ros version in this file:
https://github.com/PointCloudLibrary/pcl/blob/master/.dev%2Fdocker%2Fperception_pcl_ros%2Fmelodic_rosinstall.yaml

Some git checkouts?

@mvieth
Copy link
Member Author

mvieth commented Feb 6, 2025

Oh yes, you are right, thanks. https://github.com/ros-perception/pcl_msgs indeed has a noetic-devel branch. However, for https://github.com/ros-perception/perception_pcl , there is no noetic-devel branch, and the melodic-devel branch is supposed to be used under noetic as well

@mvieth mvieth merged commit 34d096c into PointCloudLibrary:master Feb 7, 2025
13 checks passed
@mvieth mvieth deleted the fix_perception_pcl_ros_docker branch February 7, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: fix Meta-information for changelog generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants