Add all known outstanding yaml config options as of process-compose v1.7.3

[daroot]

• per-process description that displays in the UI
• global and per-process log_configuration, including rotation
• global and per-process vars for supporting Go template expansion on configs
• env_cmds allows running host commands to populate env variables
• ordered_shutdown controls the order of process shutdown
• is_strict does additional checking on configuration files at startup
• disable_env_expansion to not propagate .env variables to processes
• http_get.{headers,status_code} and working_dir for probe commands
• replicas to run multiple copies of processes
• entrypoint alternate to command
• is_elevated for sudo/runas priviledged processes
• extends,is_disabled,is_dotenv_disabled for multi-file fragments and overrides.
• launch_timeout_seconds for daemon processes

[srid]

@shivaraj-bh Does this look good to be merged?

[adrian-gierakowski]

should we also add all env vars from here to here:

process-compose-flake/nix/process-compose/cli.nix

Lines 18 to 27 in e968a94

	environment = mkOption {
	default = { };
	description = "Environment variables to pass to process-compose binary.";
	type = types.submodule {
	options = {
	PC_DISABLE_TUI = mkOption {
	type = types.nullOr types.bool;
	default = null;
	description = "Disable the TUI (Text User Interface) of process-compose";
	};

[adrian-gierakowski]

there are also some missing flags here, like disable-dotenv

[shivaraj-bh]

I want to use the options defined in this PR. Aside from 3 comments from @adrian-gierakowski and a small nit (about args) from me, this PR looks good.

[srid]

@daroot Would you like to address these, so we can merge your PR?

[daroot]

I've updated the missing env vars and addressing the args nit.

I'm less sure about adding all the individual cli options separately. Given you can do nix run -- <any command or options>, does it make sense to add any of these that are not critical to consistent functions across multiple invocations (like uds and port) or that can also already be set via env variables?

[shivaraj-bh]

I'm less sure about adding all the individual cli options separately. Given you can do nix run -- , does it make sense to add any of these that are not critical to consistent functions across multiple invocations (like uds and port) or that can also already be set via env variables?

@daroot
It is nice to define all the possible CLI options for the sake of completeness of the process-compose.cli module.

It might seems like a rather strange use-case, but:

I often use these settings to enforce certain cli options on the users of the app. For example,process-compose.cli.unix-socket = “<my-path>"; will prevent users (IIRC) from shooting oneself in the foot with PC_SOCKET_PATH env var that (unknowingly) might point to some other path in the users environment.

[shivaraj-bh]

It is nice to define all the possible CLI options for the sake of completeness of the process-compose.cli module.

These are not very crucial (as one can still use CLI args). Can be added later if needed

[robinanterior]

Did the entrypoint option ever make it to actually become an alternative for command? I see the option declaration but I don't see it ever being referenced in this PR, and when I use it, I get an eval error because it still seems to reference command. I can debug further but I wanted to sanity check that it's normal for there to be no other reference to entrypoint here than the option declaration?

[shivaraj-bh]

and when I use it, I get an eval error because it still seems to reference command

entrypoint is overridden by command if present.

process-compose-flake/nix/process-compose/settings/process.nix

Lines 275 to 278 in 3667881

	description = ''
	Specifies the process command as a list of arguments.
	Overridden by the command option if it is present.
	'';

[robinanterior]

and when I use it, I get an eval error because it still seems to reference command

entrypoint is overridden by command if present.

process-compose-flake/nix/process-compose/settings/process.nix

Lines 275 to 278 in 3667881

	description = ''
	Specifies the process command as a list of arguments.
	Overridden by the command option if it is present.
	'';

Was that functionality [rather than the option that declares it] introduced in a different PR? Or is that overriding handled by code outside of this codebase ?

[shivaraj-bh]

Was that functionality [rather than the option that declares it] introduced in a different PR? Or is that overriding handled by code outside of this codebase ?

This behaviour is defined in https://github.com/F1bonacc1/process-compose/blob/0d943455017c8eb9a9dfd2c192456df1667a17c4/src/app/process.go#L273-L279.

(This should probably be mentioned in PC docs)

[robinanterior]

Thanks @shivaraj-bh I didn't realize it was passed through verbatim to PC. In that case I think there's a bug somewhere, issue opening in #110.