Allow warhead to only affect invoker#2237
Open
DeathFishAtEase wants to merge 5 commits into
Open
Conversation
|
To Chinese users:
|
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Contributor
|
Just an reminder , if you do keep old invoker pointer always make sure that is really valid invoker , because in the middle of damaging/detonating state the invoker itself may get killed or deleted and need to be cleanup , if you keep it like this that mean you will potentially referencing an dangling pointer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Droppingand extremely smallCellSpreadto prevent a weapon fired by a unit from affecting others, thereby achieving complex combination logic. However, existing methods merely reduced the range of affected objects through various means. Now, you can directly use the following flag to check whether the victim is the unit itself:AffectsInvokerOnlycan be used to make the affected object only the unit itself.AffectsInvokerOnly.Reversecan be used to exclude the unit from the affected objects.AffectsInvokerOnly.IgnoreInvokerStatecan be used to determine whether to consistently avoid affecting other objects regardless of the unit's state.Tip
If you have enabled
ApplyPerTargetEffectsOnDetonateto make affects handling completely follow damage propagation, then most of the time you can just useDamageSelfandAllowDamageOnSelfwithout needingAffectsInvokerOnly.Reverse.