Skip to content

Recipient-specific message and EVA on superweapon activation#2196

Open
Flactine wants to merge 9 commits into
Phobos-developers:developfrom
Flactine:EVA_Activated_Firer
Open

Recipient-specific message and EVA on superweapon activation#2196
Flactine wants to merge 9 commits into
Phobos-developers:developfrom
Flactine:EVA_Activated_Firer

Conversation

@Flactine
Copy link
Copy Markdown
Contributor

@Flactine Flactine commented May 4, 2026 •
edited
Loading

Adds recipient-specific message and EVA tags for superweapons:

[SOMESW]                        ; SuperWeaponType
Message.Activated.Owner=        ; CSF entry key
Message.Activated.Allies=       ; CSF entry key
Message.Activated.Enemies=      ; CSF entry key

EVA.Activated.Owner=            ; EVA entry
EVA.Activated.Allies=           ; EVA entry
EVA.Activated.Enemies=          ; EVA entry

@phoboscn-bot
Copy link
Copy Markdown

phoboscn-bot commented May 4, 2026

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户：
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息：

https://www.phoboscn.top/t/topic/408/1

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026 •
edited
Loading

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Flactine Flactine changed the title Firer-only EVA on superweapon activated Firer-only Message and EVA on superweapon activated May 4, 2026
TaranDahl
TaranDahl requested changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@TaranDahl TaranDahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use AffectedHouses enum plz

@TaranDahl
Copy link
Copy Markdown
Contributor

TaranDahl commented May 5, 2026

Or maybe EVA.Activated.Owner/Allies/Enemies could be better?

TaranDahl
TaranDahl reviewed Jun 2, 2026
View reviewed changes
Comment thread src/Ext/SWType/FireSuperWeapon.cpp Outdated
@Flactine Flactine changed the title Firer-only Message and EVA on superweapon activated Recipient-specific message and EVA on superweapon activation Jun 2, 2026
@DeathFishAtEase DeathFishAtEase added Needs testing ⚙️T1 T1 maintainer review is sufficient labels Jun 2, 2026
@Flactine Flactine requested a review from TaranDahl June 2, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TaranDahl TaranDahl TaranDahl approved these changes

Assignees

No one assigned

Labels

Needs improvement Needs testing ⚙️T1 T1 maintainer review is sufficient

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Flactine @phoboscn-bot @TaranDahl @DeathFishAtEase