Only prefetch texture overrides on first init#34
Open
niligulmohar wants to merge 1 commit intoPeterTh:masterfrom
Open
Only prefetch texture overrides on first init#34niligulmohar wants to merge 1 commit intoPeterTh:masterfrom
niligulmohar wants to merge 1 commit intoPeterTh:masterfrom
Conversation
If texture override and texture prefetch was enabled, all overridden textures would be loaded again every time the D3D device was reset, for example when re-entering fullscreen mode again after alt-tabbing away from DS. The already loaded textures would not be freed, leading to a significant memory leak. This change makes prefetching happen only on the first init, and should fix PeterTh#32.
|
i can confirm that whilst it might run better it does not fix the issue that spawned it; i still cannot alt-tab dark souls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If texture override and texture prefetch was enabled, all overridden
textures would be loaded again every time the D3D device was reset, for
example when re-entering fullscreen mode again after alt-tabbing away from
DS. The already loaded textures would not be freed, leading to a
significant memory leak.
This change makes prefetching happen only on the first init, and should
fix #32.