fix(doctor): stop flagging pip console-script symlink as legacy shim (#252) - #686
Merged
Merged
Conversation
…252) The stale-shim check treated ANY ~/.local/bin/perseus symlink as a legacy install.sh shim, so the recommended stable-pointer setup (a symlink to the pip-installed console entry-point) always produced a false 'Legacy shim' warning. Resolve the symlink target and treat it as current when it is a pip entry-point script (contains 'from perseus import main'); only warn on genuine /bin/sh shims or references to the old ~/.local/share/perseus/perseus.py bundle.
tcconnally
added a commit
that referenced
this pull request
Aug 30, 2026
…252) (#686) The stale-shim check treated ANY ~/.local/bin/perseus symlink as a legacy install.sh shim, so the recommended stable-pointer setup (a symlink to the pip-installed console entry-point) always produced a false 'Legacy shim' warning. Resolve the symlink target and treat it as current when it is a pip entry-point script (contains 'from perseus import main'); only warn on genuine /bin/sh shims or references to the old ~/.local/share/perseus/perseus.py bundle. Co-authored-by: Thomas Connally <greg@weirdplexbutok.biz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_doctor_check_stale_shimtreated any~/.local/bin/perseussymlink as a legacyinstall.shshim. The recommended stable-pointer setup — a symlink from~/.local/bin/perseusto the pip-installed console entry-point (e.g.~/Library/Python/3.x/bin/perseus) — therefore always produced a false⚠ Legacy shimwarning, even on a clean, current pip install.Fix
Resolve the symlink target and inspect the real script:
from perseus import main/import perseus)./bin/shshim or a reference to the old~/.local/share/perseus/perseus.pybundle.The legacy
share_pathcheck is unchanged.Verification
python3 scripts/build.pyregeneratesperseus.py(smoke test ok, v1.0.19).perseus doctoron a symlink-to-pip-console-script setup now reports✓ Legacy shim shim at ~/.local/bin/perseus looks current(previously⚠)./bin/shshim / legacy bundle still warns.Both the source module (
src/perseus/doctor.py) and the builtperseus.pyare updated.