embed.pl: Fix BBC build failures #24196, #24197#24200
Open
khwilliamson wants to merge 2 commits intoPerl:bleadfrom
Open
embed.pl: Fix BBC build failures #24196, #24197#24200khwilliamson wants to merge 2 commits intoPerl:bleadfrom
khwilliamson wants to merge 2 commits intoPerl:bleadfrom
Conversation
Fixes Perl#24196 Fixes Perl#24197 This bug stemmed from a C preprocessor nuance that I was unaware of. It only happened on unthreaded builds and only affected functions that have a single argument, the thread context, so that on unthreaded builds, these have 0 parameters. The preprocessor dropped the parens indicating there is an argument list (empty), which led to compilation errors. It does not do this if there is at least one argument besides the thread context one. The solution is to extend the use of a paradigm already in effect for other situations, so that there is a placeholder argument for the thread context that gets dropped. This is only defined on unthreaded builds. It is cleaner to do this for unaffected functions as well, (those that have an argument besides the thread context). Threaded is unchanged.
On unthreaded builds, the elements changed by this commit are macros, so a prototype is useless. Simply #ifdef them to threaded only.
Contributor
|
I installed a local branch derived from this p.r. and built an unthreaded perl on Linux. I was then able to install Sys::Ibam and Wifi::WpaCtrl against that perl. So in terms of the original complaint, this DWIMs. perlguts code should get additional eyeballs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24196
Fixes #24197
This bug stemmed from a C preprocessor nuance that I was unaware of. It
only happened on unthreaded builds and only affected functions that have
a single argument, the thread context, so that on unthreaded builds,
these have 0 parameters. The preprocessor dropped the parens indicating
there is an argument list (empty), which led to compilation errors.
It does not do this if there is at least one argument besides the thread
context one.
The solution is to extend the use of a paradigm already in effect for
other situations, so that there is a placeholder argument for the thread
context that gets dropped. This is only defined on unthreaded builds.
It is cleaner to do this for unaffected functions as well, (those that
have an argument besides the thread context).
Threaded is unchanged.