Add comprehensive tests for ERC-20 Permit extension (EIP-2612)#60
Closed
panditdhamdhere wants to merge 1 commit intoPerfect-Abstractions:mainfrom
Closed
Add comprehensive tests for ERC-20 Permit extension (EIP-2612)#60panditdhamdhere wants to merge 1 commit intoPerfect-Abstractions:mainfrom
panditdhamdhere wants to merge 1 commit intoPerfect-Abstractions:mainfrom
Conversation
- Create MockERC20Facet for proper test initialization - Test success paths: valid signatures, nonce increments, sequential permits - Test failure paths: expired deadlines, reused signatures, wrong signer - Test edge cases: zero value approvals, max uint256 values Resolves Perfect-Abstractions#59
Contributor
|
@panditdhamdhere Do we still need this PR? Or can we close it now that we have PR #78 ? |
Collaborator
Author
|
Yes thank you @mudgen ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #59