refactor(categories, comments): remove Bootstrap.js#637
Open
hno2 wants to merge 1 commit intoPelican-Elegant:nextfrom
hno2:nobootstrapjs
Open
refactor(categories, comments): remove Bootstrap.js#637hno2 wants to merge 1 commit intoPelican-Elegant:nextfrom hno2:nobootstrapjs
hno2 wants to merge 1 commit intoPelican-Elegant:nextfrom
hno2:nobootstrapjs
Conversation
Removing Bootstrap.js in the base.html requires a refactor to make the accordions on the categories page and in the comment section work correctly. This commit refactores the accordion with a hidden checkbox and some css. Aditionally some js was changed to allow anchorlinking to a specific category and opening it.
Author
|
Are there any issues with my Request or any ETA for when this can/will be merged ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
nextbranchRecommended Steps
Description
Removing Bootstrap.js in the base.html requires a refactor to make the accordions on the categories
page and in the comment section work correctly. This commit refactores the accordion with a hidden
checkbox and some css. Additionally some JavaScript was changed to allow anchor linking to a specific category
and opening it. The existing jQuery was refactored to vanilla js. This is part of the ongoing progress to remove Bootstrap completly in Pull Request #500 and Issue #429.
Thanks for your help in advance. Please be kind, this is my first real pull request to Open Source and I am not a JavaScript God. (Sorry for any mistakes, hope I followed all guidelines.)