Skip to content

in CI, regen all mechanisms and check if there are diffs - #659

Draft
baperry2 wants to merge 7 commits into
Pele-Suite:developmentfrom
baperry2:ceptr-check-mech
Draft

in CI, regen all mechanisms and check if there are diffs#659
baperry2 wants to merge 7 commits into
Pele-Suite:developmentfrom
baperry2:ceptr-check-mech

Conversation

@baperry2

Copy link
Copy Markdown
Contributor

This is to ensure that the committed mechanisms are always consistent with CEPTR. Sometimes people (e.g., me) will update CEPTR and not regenerate all the mechanisms, and the mechanisms that didn't get updated become non-functional.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CEPTR CI job to regenerate all committed chemical mechanisms during CI and fail the build if regeneration changes any tracked files, preventing stale/non-functional committed mechanisms after CEPTR updates.

Changes:

  • Replace per-mechanism conversion steps with list-driven conversion for all “regular” mechanisms.
  • Add QSS regeneration (qssa + convert) from a QSS mechanism list.
  • Add git diff --exit-code checks to fail CI when regeneration modifies tracked files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
@baperry2
baperry2 marked this pull request as draft February 25, 2026 19:04
@baperry2

Copy link
Copy Markdown
Contributor Author

This might not be viable due to sensitivities in how CEPTR generation that can lead to tirvial differences when mechanisms are regenerated. Going to leave this as a draft.

@baperry2

Copy link
Copy Markdown
Contributor Author

@copilot: it seems like the machine generated code from CEPTR can have small variations sometimes, perhaps due to the system it is being run on or differences in dependency versions. Can you suggest what needs to be done within PelePhysics to make the output fully consistent, such that any diffs indicate actual changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants