Ensure settings$database defaults to NULL when absent#3714
Merged
mdietze merged 2 commits intoPecanProject:developfrom Dec 10, 2025
Merged
Ensure settings$database defaults to NULL when absent#3714mdietze merged 2 commits intoPecanProject:developfrom
mdietze merged 2 commits intoPecanProject:developfrom
Conversation
Signed-off-by: Aritra Dey <adey01027@gmail.com>
Signed-off-by: Aritra Dey <adey01027@gmail.com>
mdietze
approved these changes
Dec 10, 2025
Merged
via the queue into
PecanProject:develop
with commit Dec 10, 2025
09ea6c9
19 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, both Demo notebooks use a workaround to set settings$database to NULL, even though the configuration is absent in the settings file.
pecan/documentation/tutorials/Demo_02_Uncertainty_Analysis/uncertainty.qmd
Lines 123 to 125 in 381c450
The issue arises because
prepare.settingsautomatically addssettings$database$dbfileseven ifsettings$databaseis initially absent. (see #3701 (comment)).This PR fixes the issue by modifying
check.settingsto only setsettings$database$dbfilesifsettings$databaseis already present (i.e., not NULL). This ensures thatsettings$databaseremainsNULLwhen no database configuration is provided.Also, after the fix, inspecting the
settingsobject confirms that there is NOsettings$databasepresent.Motivation and Context
Fixes #3701
Review Time Estimate
Types of changes
Checklist: