fix(base/db): pass database connection to get_machine_info#3700
Merged
infotroph merged 1 commit intoPecanProject:developfrom Dec 5, 2025
Merged
fix(base/db): pass database connection to get_machine_info#3700infotroph merged 1 commit intoPecanProject:developfrom
infotroph merged 1 commit intoPecanProject:developfrom
Conversation
It will fix the issue of 'No parameters or connection specified' while convert_input Signed-off-by: Aritra Dey <adey01027@gmail.com>
mdietze
approved these changes
Dec 5, 2025
Member
|
Thank you for the patch! Caution for future readers with superficially similar issues: This fixes a failure in cases where your run has an active DB connection. Making |
Merged
via the queue into
PecanProject:develop
with commit Dec 5, 2025
f60dadd
20 of 27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, any function using
convert_inputfails with the following error becauseget_machine_infois missing a database connection:This PR passes the existing database connection
contoget_machine_infowithinconvert_input.Rto resolve this error.Motivation and Context
Review Time Estimate
Types of changes
Checklist: