add path to hdf5 path in build process to allow easier testing#1642
Draft
oganm wants to merge 1 commit intohotfix-1.32.7from
Draft
add path to hdf5 path in build process to allow easier testing#1642oganm wants to merge 1 commit intohotfix-1.32.7from
oganm wants to merge 1 commit intohotfix-1.32.7from
Conversation
arteymix
reviewed
Mar 26, 2026
| </programs> | ||
| <!-- this allows Log4j 2 to lookup for Log4j 1.2 configuration --> | ||
| <extraJvmArguments>${jvmOptions}</extraJvmArguments> | ||
| <extraJvmArguments>-Djava.library.path=${hdf5.libDir} ${jvmOptions}</extraJvmArguments> |
Member
There was a problem hiding this comment.
This is a very bad idea. It will be included in the Appassembler package and will literally break deployment.
If you need to make testing easier, you can add a line like this to a .env or .envrc file:
export JAVA_OPTS="-Djava.library.path=/path/to/hdf5-1.12.3/lib"
Member
There was a problem hiding this comment.
The only place we pass this is in testJvmOptions because building and testing is done on the same machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.