Skip to content

Allow DEA to be performed on a subset of the samples#1627

Open
arteymix wants to merge 8 commits intohotfix-1.32.7from
feature-dea-on-sample-subset
Open

Allow DEA to be performed on a subset of the samples#1627
arteymix wants to merge 8 commits intohotfix-1.32.7from
feature-dea-on-sample-subset

Conversation

@arteymix
Copy link
Copy Markdown
Collaborator

No description provided.

@arteymix
Copy link
Copy Markdown
Collaborator Author

@maubermann this is relevant for you

@arteymix arteymix force-pushed the feature-dea-on-sample-subset branch from 0c98f3f to 634727f Compare February 24, 2026 18:59
@arteymix arteymix force-pushed the feature-dea-on-sample-subset branch from 634727f to 8df721e Compare February 24, 2026 19:21
@maubermann maubermann marked this pull request as ready for review February 24, 2026 19:24
@arteymix
Copy link
Copy Markdown
Collaborator Author

arteymix commented Mar 8, 2026

@oganm you should trigger the integration tests with FORCE_INTEGRATION_TESTs in Jenkins.

Jenkins is set up to report which stages of the build were performed, but it stopped working once I migrated to use @ppavlidis' token.

@oganm
Copy link
Copy Markdown
Member

oganm commented Mar 10, 2026

samples currently only accepts IDs, full names (i.e. "GSE2018_bioMaterial_11|GSM36433" for sample 24 of GSE2018). Accessions don't seem to be working

@oganm
Copy link
Copy Markdown
Member

oganm commented Mar 10, 2026

Using accessions and names have minor issues related to #1640 but using them as returned by Gemma samples endpoint or anything that relies on an ExpressionExperiment object should be fine

@arteymix
Copy link
Copy Markdown
Collaborator Author

@oganm we typically don't assign accessions to BioMaterial, but to BioAssay. I made this specifically for resolving samples, but you could add additional checks for assays too.

@arteymix arteymix force-pushed the feature-dea-on-sample-subset branch from b1a8cd7 to da82fa2 Compare March 12, 2026 16:04
@arteymix arteymix force-pushed the feature-dea-on-sample-subset branch 2 times, most recently from e5aeb0f to d184f3d Compare March 12, 2026 16:16
@arteymix arteymix force-pushed the feature-dea-on-sample-subset branch from d184f3d to 2019886 Compare March 12, 2026 16:16
}
return result;
}

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oganm I haven't tested these two queries, but the idea is to fetch all the samples with the assay they belong to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants