Draft
Conversation
arteymix
force-pushed
the
deployment-script-improvements
branch
from
e83d3d4 to
86f6d48
Compare
arteymix
force-pushed
the
deployment-script-improvements
branch
from
86f6d48 to
e8556d5
Compare
arteymix
commented
Feb 14, 2026
| [confirm('Deploying to production manually is very dangerous. Proceed?')] | ||
| deploy-web-production: | ||
| just --justfile "{{justfile()}}" --set GEMMA_WEB_DEPLOY_SERVER {{PRODUCTION_DEPLOY_SERVER}} deploy-web 'gemma' | ||
|
|
Member
Author
There was a problem hiding this comment.
@oganm I've added some tasks with confirmation in case you need to deploy to production manually.
arteymix
force-pushed
the
deployment-script-improvements
branch
from
e8556d5 to
29deb31
Compare
arteymix
commented
Feb 14, 2026
|
|
||
| maven_site_dir=$($MAVEN help:evaluate -Dexpression=pavlab.siteDir -q -DforceStdout) | ||
| gemma_version=$($MAVEN help:evaluate -Dexpression=project.version -q -DforceStdout) | ||
| basecode_version=$($MAVEN help:evaluate -Dartifact=baseCode:baseCode -Dexpression=project.version -q -DforceStdout) |
Member
Author
There was a problem hiding this comment.
One important caveat here, mvnd does not appear to be capable of evaluating expression, or at least not with this syntax, so we need to make sure that we're using vanilla Maven.
arteymix
commented
Feb 14, 2026
| else | ||
| # TODO: default to local deployment | ||
| deploy_server=$($MAVEN help:evaluate -Dexpression=pavlab.server -q -DforceStdout) | ||
| fi |
Member
Author
There was a problem hiding this comment.
To mimic what maven does, we need to check if a local deployment is performed and then only use the maven_site_dir as-is. Otherwise, it needs to be used through ssh.
arteymix
commented
Feb 14, 2026
| [confirm('Deploying to production manually is very dangerous. Proceed?')] | ||
| deploy-web-production: | ||
| just --justfile "{{justfile()}}" --set GEMMA_WEB_DEPLOY_SERVER {{PRODUCTION_DEPLOY_SERVER}} deploy-web 'gemma' | ||
|
|
Member
Author
There was a problem hiding this comment.
A deployment to production should probably include a call to clean-web for safety.
arteymix
commented
Feb 14, 2026
| deploy-cli ref: build-cli update-completion-scripts | ||
| ./gemma-cli/deploy.sh "{{ref}}" | ||
|
|
||
| [confirm('Deploying to production manually is very dangerous. Proceed?')] |
Member
Author
There was a problem hiding this comment.
Include a clean-cli when deploying to production.
arteymix
force-pushed
the
deployment-script-improvements
branch
3 times, most recently
from
ac18387 to
4e08605
Compare
Relocate deployment scripts in a single scripts/ location.
arteymix
force-pushed
the
deployment-script-improvements
branch
from
4e08605 to
c38172c
Compare
arteymix
commented
Feb 17, 2026
| # This is the general deployment server | ||
| DEPLOY_SERVER := "frink.pavlab.msl.ubc.ca" | ||
| PRODUCTION_DEPLOY_SERVER := "moe.pavlab.msl.ubc.ca" | ||
| DEVELOPMENT_DEPLOY_SERVER := "chalmers.pavlab.msl.ubc.ca" |
Member
Author
There was a problem hiding this comment.
These should be defined externally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gemma-cli-custom-build) with completion