Skip to content

hiding expression and qc windows when no data is present #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oganm wants to merge 2 commits into
base: hotfix-1.32.6
Choose a base branch
from
Open

hiding expression and qc windows when no data is present #1607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e12f6a1
hides diagnostics and expression visualization. produces unavoidable …
oganm Feb 5, 2026
6d34d10
handling empty data
oganm Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions gemma-web/src/main/webapp/scripts/api/entities/experiment/ExpressionExperimentPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,25 @@ Gemma.ExpressionExperimentPage = Ext.extend( Ext.TabPanel, {
}
},

checkData: function( eeId, geneList, callback ){
// checks to see if a dataset has expression data to prevent the relevant tabs from
// being shown
var store = new Gemma.VisualizationStore()
store.on( 'exception', function( e,type, action, options, response, arg ){
Ext.callback(callback,this,[false])
})

store.load({
params: [ [ eeId ], geneList || [] ],
callback: function (records, options, success) {
var hasData = !!(success && records && records.length > 0);
callback(hasData);
},
scope: this
});

},

/**
* @memberOf Gemma.ExpressionExperimentPage
*/
Expand Down Expand Up @@ -148,12 +167,18 @@ Gemma.ExpressionExperimentPage = Ext.extend( Ext.TabPanel, {

// EXPERIMENT DESIGN TAB
this.add( this.makeDesignTab( experimentDetails ) );
this.checkData(experimentDetails.id,[],function(hasData){
if(hasData){
// VISUALISATION TAB
this.add( this.makeVisualisationTab( experimentDetails, isAdmin ) );

// DIAGNOSTICS TAB
this.add( this.makeDiagnosticsTab( experimentDetails, isAdmin ) );
}
}.createDelegate(this))


// VISUALISATION TAB
this.add( this.makeVisualisationTab( experimentDetails, isAdmin ) );

// DIAGNOSTICS TAB
this.add( this.makeDiagnosticsTab( experimentDetails, isAdmin ) );

this.adjustForIsAdmin( isAdmin, this.editable );

Expand Down Expand Up @@ -208,6 +233,8 @@ Gemma.ExpressionExperimentPage = Ext.extend( Ext.TabPanel, {
};
},



makeVisualisationTab : function( experimentDetails, isAdmin ) {
var eeId = this.eeId;
var title = "Data for a 'random' sampling of probes";
Expand Down
11 changes: 9 additions & 2 deletions gemma-web/src/main/webapp/scripts/api/visualization/VisualizationWidget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1199,7 +1199,7 @@ Gemma.VisualizationStore = function( config ) {
}, this.record );

Gemma.VisualizationStore.superclass.constructor.call( this, config );

this.relayEvents( this.proxy, [ 'loadexception' ] );

};
Expand All @@ -1210,7 +1210,14 @@ Gemma.VisualizationStore = function( config ) {
* @extends Ext.data.Store
*/

Ext.extend( Gemma.VisualizationStore, Ext.data.Store, {} );
Ext.extend( Gemma.VisualizationStore, Ext.data.Store, {
loadRecords: function(o, options,success){
if (!o.records){
o.records = []
}
return Gemma.VisualizationStore.superclass.loadRecords.call(this,o, options, success)
}
} );

// //////////////////////////////////////////////////////////////////////////////////

Expand Down