feat: make search results scrollable#35
feat: make search results scrollable#35benediktms wants to merge 4 commits intoParthJadhav:masterfrom
Conversation
|
@ParthJadhav Do you know if the Tauri web vies support custom scroll bars? Only resources I could find on this are firefox specific or use webkit. But it seems Tauri doe snot support this (see below). The functionalty works, but the scroll bar is quite ugly... One option is to simply hide it and hope the user understands tha thtey can just scroll 🤷♂️
|
| <style> | ||
| .container { | ||
| height: 100%; | ||
| height: 350px; |
There was a problem hiding this comment.
Shouldn't this be 100% ? Cause that makes the window large but without anything inside...
There was a problem hiding this comment.
Yes true probably something like
height: 100%;
max-height: 350px;is needed
|
So, I checked the code and there are few problems with that..
My suggestion would be to load around 10 results at search. And keep loading other results on a separate thread to around 50 results. I guess 50 results would be sufficient. i'd like to know your opinions on it. |
|
Yes that makes sense. I'll experiment a bit with this and let you know 👍 |
added type signatures to: - icons cache - getIcons function
|
@ParthJadhav few things I'd like to ask:
|
|
Well, I guess it's not needed at all. Sorry for the wrong tip. I don't think it would cost a lot to get few results. Let's do 15 results. I don't think any human would scroll more then 15 results if he didn't find his answer in first 5 or 8. So Lets just change the limit from 5 to 15... |
benediktms
force-pushed
the
add-scroll-to-search-results
branch
from
87b3e23 to
2df1bf4
Compare
|
@ParthJadhav I'm not happy with the scroll bars but I am unsure how to style them if the webviews don't support CSS for this |
benediktms
changed the title
|
Idk why my scroll bar looks better😄 |
|
Hmm are you using any global themes or something? |
|
Nope @benediktms |
2 participants
Closes #3