Preserve rotation on teleport command and add PlayerChangedWorldEvent for teleportAsync#395
Open
luigiofthebakery wants to merge 2 commits intoPaperMC:ver/1.21.8from
Open
Preserve rotation on teleport command and add PlayerChangedWorldEvent for teleportAsync#395luigiofthebakery wants to merge 2 commits intoPaperMC:ver/1.21.8from
luigiofthebakery wants to merge 2 commits intoPaperMC:ver/1.21.8from
Conversation
luigiofthebakery
force-pushed
the
fixes2
branch
from
89be6e7 to
9f8757c
Compare
Euphillya
reviewed
Sep 22, 2025
Comment on lines
+14735
to
+14738
| + this.getBukkitEntity().taskScheduler.schedule((Entity entity) -> { | ||
| + org.bukkit.event.player.PlayerChangedWorldEvent changeEvent = new org.bukkit.event.player.PlayerChangedWorldEvent(((ServerPlayer)entity).getBukkitEntity(), from); | ||
| + org.bukkit.Bukkit.getPluginManager().callEvent(changeEvent); | ||
| + }, null, 1L); |
Contributor
There was a problem hiding this comment.
I don't think this is the good solution, because here we have 1 tick delay after the player has changed world
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the teleport command, rotation (pitch and yaw) was not preserved when teleporting to an entity, or in any situation where it wasn't explicitly specified in the command parameters. The first commit fixes that.
The second commit adds back PlayerChangedWorldEvent to fire after teleportAsync is called, if the entity is a player and they are teleporting to a new world.