fix destroy team membership when user is not the active on-call#914
Open
twix14 wants to merge 1 commit intoPagerDuty:masterfrom
Open
fix destroy team membership when user is not the active on-call#914twix14 wants to merge 1 commit intoPagerDuty:masterfrom
twix14 wants to merge 1 commit intoPagerDuty:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cjgajard
added a commit
to cjgajard/terraform-provider-pagerduty
that referenced
this pull request
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292
If a user was not active in the on-call rotation it wouldn't be temporarily dissociated from the associated EPs, because the on-call list call never returned non-active users.
Getting the EPs where the user is active from now to 90 days (On-call shifts are limited to 90 days in the future) in the future fixes the issue.