fix: allow mixing of implicit and explicit arguments#1698
Open
fix: allow mixing of implicit and explicit arguments#1698
Conversation
Build Artifacts🐧 Linux
From workflow run 🪟 Windows
From workflow run |
ghaith
reviewed
Apr 24, 2026
Collaborator
There was a problem hiding this comment.
Idle thought, we can make our life much easier if the call lowerer would solve this:
- Re-order the paramters,
- Make everything either formal or not
- Fill in missing parameters with the default value
But we need to make sure we still hit the validation.
not saying you should do it now, just thought it might make it easier
volsa
reviewed
Apr 24, 2026
| PROGRAM main | ||
| VAR x : INT; END_VAR | ||
| // `1` sits in position 0 (param `a`), but `a := 10` also targets `a`. | ||
| // The resolver silently reinterprets the call as `a := 10, b := 1`. |
Member
There was a problem hiding this comment.
I'd remove this line, you're leaking internal architecture to the user. A user probably doesn't know what a resolver is nor do they care.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.