Conversation
Build Artifacts🪟 Windows
From workflow run 🐧 Linux
From workflow run |
volsa
reviewed
Apr 17, 2026
volsa
reviewed
Apr 22, 2026
Comment on lines
+145
to
+146
| matches!(expr.get_stmt(), AstStatement::Literal(AstLiteral::Integer(_))) | ||
| || !matches!(expr.get_stmt(), AstStatement::Literal(_)) |
Member
There was a problem hiding this comment.
((1)) will probably not work since you need to peel it?
Collaborator
Author
There was a problem hiding this comment.
did some basic tests, it seems to be fine, but i'll push a followup with a peel
Collaborator
Author
There was a problem hiding this comment.
or not there's a merge conflict anyway
volsa
reviewed
Apr 22, 2026
| matches!(expr.get_stmt(), AstStatement::Literal(AstLiteral::Integer(_))) | ||
| || !matches!(expr.get_stmt(), AstStatement::Literal(_)) | ||
| } else { | ||
| type_info.is_int() && !type_info.is_bool() && !type_info.is_date_or_time_type() |
Member
There was a problem hiding this comment.
Perhaps a comment that bool and date/time are also resolved as integers in the type info hence the explicit check
Collaborator
Author
There was a problem hiding this comment.
will add in a followup
volsa
previously approved these changes
Apr 22, 2026
volsa
previously approved these changes
Apr 23, 2026
volsa
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.