Skip to content

Replace untagged portions of asset download urls with the tag name - #100

Open
F0bes wants to merge 2 commits into
mainfrom
untagged-shmoo
Open

Replace untagged portions of asset download urls with the tag name#100
F0bes wants to merge 2 commits into
mainfrom
untagged-shmoo

Conversation

@F0bes

@F0bes F0bes commented Sep 4, 2026

Copy link
Copy Markdown
Member

No description provided.

@TellowKrinkle

Copy link
Copy Markdown
Member

BTW GitHub seems to send updates like this:
image

The last one (the release.published) had the correct URLs, but the one before it (release.edited) did not. Somehow after this, the website was continuing to display the unpublished URLs.

Do we maybe have a race somewhere?

@TellowKrinkle

TellowKrinkle commented Sep 6, 2026

Copy link
Copy Markdown
Member

Actually there's one more after that, and it contains pre-publish data (bad URLs):
image

It has "updated_at": "2026-09-06T03:29:34Z",, while the publish has "updated_at": "2026-09-06T03:29:35Z",

So I think it started at 22:29:35 and waited until 22:29:45 before GitHub decided that it timed out

@TellowKrinkle

TellowKrinkle commented Sep 6, 2026

Copy link
Copy Markdown
Member

It might make more sense to only accept updates if their updated_at is greater than the last one we accepted rather than patching URLs and hoping for the best.

Or maybe easier would be to ignore events with "published_at": null, though that would still be susceptible to legitimate edits to published releases arriving out of order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants