Dev - Support primary or alternate option to choose the file system#100
Open
pioneerAlone wants to merge 2 commits intoP1sec:masterfrom
Open
Dev - Support primary or alternate option to choose the file system#100pioneerAlone wants to merge 2 commits intoP1sec:masterfrom
pioneerAlone wants to merge 2 commits intoP1sec:masterfrom
Conversation
Member
|
Hello! Thank you for your pull request. In the source code, I see: It seems that the documentation talks about choosing between I think that it could more clean and easy to use to keep two separate arguments, like Regards, |
Author
|
I think that it could more clean and easy to use to keep two separate arguments, like --efs2-shell and --efs-shell, so that backwards compatibility is preserved and there is less to type for the user.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello ,
I mentioned before on this issue#99 that I hope this library supports access to the alternate file system of Qualcomm modules. After my research, I implemented it. Since the library can only access the primary file system by default, few users usually change it. , most of the time, the alternate file system will be operated to read/write some user information.
So I open a pull request. If it is helpful to you, you can adopt it. If there are any problems, please let me know.
Regards,
Bakewell
Below are examples,
#1 Access primary file system with 'efs' option
#2 Access primary file system with 'efs2' option