Skip to content

raidboss: Windurst Third Walk triggers#1061

Draft
JLGarber wants to merge 1 commit into
OverlayPlugin:mainfrom
JLGarber:windurst-third-walk-triggers
Draft

raidboss: Windurst Third Walk triggers#1061
JLGarber wants to merge 1 commit into
OverlayPlugin:mainfrom
JLGarber:windurst-third-walk-triggers

Conversation

@JLGarber
Copy link
Copy Markdown
Collaborator

There is A Lot in here. Windurst ended up being substantially more complex than I had expected. I'm not really happy with some of this stuff, but this is the best I've got after a couple weeks of effort. There are some superfluous comments that will probably be best cleaned up before merging once this is fully reviewed.

Shantotto is mostly fine. I don't like the wide-open collection of ActorSetPos for the fire locations, but getCombatants would not return fully accurate positions for the ley lines when called during the tether mechanic, and this was the best compromise I could come up with.

Alexander is fairly okay. I'm still not 100% sure on how to handle Radiant Sacrament, or whether that's even something we should bother with since it's got very clear visuals.

Promathia has a lot of annoying elements to it. I wasn't able to make any serious use of the mapEffect data that accompanies Empty Salvation, so the triggers currently operate off the Explosion casts at the puddle destinations. This works, but it's not quite as much warning for the user as I would like.

We can't really reduce the amount of data collection we do for Promathia in any event. Post-intermission, Wheel of Impregnability and Bastion of Twilight are used at random during their positions in the timeline, so we need to ensure that all the various combinations with Pestilent Penance are handled.

The intermission sometimes calls Promyvion for a given player even if they aren't on its platform. I'm not sure whether this is a logic error on my part or something to do with getCombatants that I don't fully understand.

Shinryu/Hollow King are largely okay. It might be worth putting a countdownSeconds on the gaze/stop mechanics, but I didn't do that for this current iteration. Note that there's a missing timeline trigger for Gyre Charge, which I'll add in once the timeline package is merged.

I'm marking this as a draft because I'm confident there are better ways to address some of the triggers I've included here. Because this has all ended up being so complex, there's a good chance I've missed some obvious improvements due to being too close to this for the past couple of weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant