[#513] Add Bullet List component by ludovic35 · Pull Request #1279 · Orange-OpenSource/ouds-ios

ludovic35 · 2026-01-28T17:05:37Z

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

(#513)

Description

Motivation & Context

Types of change

New feature (non-breaking change which adds functionality)

Previews

Checklist

Contribution

I have read the contributing guidelines

Accessibility

My change follows accessibility good practices

Design

My change respects the design guidelines of Orange Unified Design System

Development

My change follows the developer guide
I checked my changes do not add new SwiftLint warnings
I have added unit tests to cover my changes (optional)

Documentation

My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

The evolution have been tested and the project builds for iPhones and iPads
Code review has been done by reviewers according to CODEOWNERS file
Design review has been done
Accessibility review has been done
Q/A team has tested the evolution
Documentation has been updated if relevant
Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
CHANGELOG has been updated respecting keep a changelog rules and reference the issues
The wiki has been updated if needed (optional)

OUDS/Core/Components/Sources/ContentDisplay/BulletList/OUDSBulletList.swift

Copilot

Pull request overview

This pull request adds a new Bullet List component to the OUDS iOS library, supporting ordered, unordered, and bare list types with up to three nested levels. The component is designed for content display and includes comprehensive documentation, theme-specific icons, and preview images.

Changes:

Added OUDSBulletList component with support for ordered/unordered/bare list types, nested items, and customizable text styles
Added new lineHeight(for:) method to MultipleFontLineHeightSemanticToken for responsive line height selection
Fixed documentation placeholders in multiple semantic token files
Added version tags to public enums across existing components (Button, Badge, Tag, TextInput, etc.)
Removed unused imports from OUDSTabBar
Corrected macOS minimum version in AGENTS.md from 15.0 to 13.0

Reviewed changes

Copilot reviewed 42 out of 58 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
OUDSBulletList.swift	Main component implementation with list types, text styles, and nested item support
OUDSBulletListItemsBuilder.swift	Result builder for declarative list item syntax
BulletListItem.swift	Internal view rendering individual list items with proper spacing and padding
Bullet.swift	Internal view handling bullet/number rendering based on list type and level
BulletTextModifier.swift	Text styling modifier for list items based on text style and bold settings
MultipleFontLineHeightSemanticToken.swift	Added new method for size-class-based line height selection
MultipleFontLineHeightSemanticTokensTests.swift	Test coverage for new line height method
MultipleSpaceSemanticToken.swift	Fixed documentation placeholder
MultipleSizeSemanticToken.swift	Fixed documentation placeholders
MultipleColorSemanticToken.swift	Added version tags to public enums
OUDSTabBar.swift	Removed unused imports
Various component files	Added version tags to public enums for API documentation
ContentDisplay.md	New documentation page for content display category with bullet list examples
Theme documentation files	Added bullet list sections with preview images for all themes
Icons.xcassets	Added bullet list icons (levels 0-2, tick) for all themes
Preview images	Added component preview images for all themes
CHANGELOG.md	Updated with bullet list component addition
NOTICE.txt	Updated with new icon asset paths
AGENTS.md	Corrected macOS minimum version from 15.0 to 13.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

OUDS/Core/Components/Sources/ContentDisplay/BulletList/OUDSBulletList.swift

OUDS/Core/Tokens/SemanticTokens/Tests/Multiples/MultipleFontLineHeightSemanticTokensTests.swift

OUDS/Core/Components/Sources/ContentDisplay/BulletList/OUDSBulletList.swift

OUDS/Core/Components/Sources/ContentDisplay/BulletList/Internal/Bullet.swift

OUDS/Core/Components/Sources/ContentDisplay/BulletList/OUDSBulletList.swift

pylapp

LGTM!

Copilot

Pull request overview

Copilot reviewed 45 out of 61 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

OUDS/Core/Components/Sources/ContentDisplay/BulletList/OUDSBulletList.swift

OUDS/Core/Tokens/SemanticTokens/Tests/Multiples/MultipleFontLineHeightSemanticTokensTests.swift

OUDS/Core/Components/Sources/_OUDSComponents.docc/ContentDisplay.md

OUDS/Core/Components/Sources/ContentDisplay/BulletList/OUDSBulletList.swift

OUDS/Foundations/Sources/OUDSUtils.swift

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

…t maxheight of bullet container to keep it alligned top

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

Acked-by: Pierre-Yves Ayoul <pierre-yves.ayoul@orange.com> Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

Acked-by: Ahmed Amine Zribi <ahmedamine.zribi@sofrecom.com> Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

ludovic35 linked an issue Jan 28, 2026 that may be closed by this pull request

Add bullet list component #513

Open

ludovic35 marked this pull request as ready for review January 29, 2026 08:18

ludovic35 requested a review from pylapp as a code owner January 29, 2026 08:18

pylapp self-assigned this Jan 29, 2026

pylapp force-pushed the 513-component-create-component---bullet-list branch 3 times, most recently from 54d5756 to 82e7f2c Compare January 29, 2026 12:29

pylapp requested changes Jan 29, 2026

View reviewed changes

OUDS/Core/Components/Sources/ContentDisplay/BulletList/OUDSBulletList.swift Show resolved Hide resolved

pylapp requested a review from Copilot January 29, 2026 14:11

Copilot started reviewing on behalf of pylapp January 29, 2026 14:11 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

pylapp previously approved these changes Jan 29, 2026

View reviewed changes

ludovic35 dismissed pylapp’s stale review via 7bf078f February 2, 2026 08:08

ludovic35 force-pushed the 513-component-create-component---bullet-list branch from 7bf078f to 4fa9c93 Compare February 2, 2026 08:09

pylapp requested a review from Copilot February 2, 2026 17:49

Copilot started reviewing on behalf of pylapp February 2, 2026 17:50 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

ludovic35 and others added 13 commits February 5, 2026 12:16

feat: Add bullet List component

c801652

refactor: to let user provide item and remove level from api

75f436d

refactor: use a builder instead of array for items

f050730

chore: update changelog

169ac4d

chore: fix swift lint issues

dd6e1ba

chore: fix swift lint issues

38078e7

chore: update documentation

d424db9

refactor: fix index in ordered list

68b5a75

refactor: remove useless generated localizables (#513)

aee40ec

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

style: various cleanings (#513)

00ab5d1

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

test: add missing unit test for line height token and size class (#513)

d6fedf9

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

docs: improve documentation and versioning (#513)

84702ac

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

style: move SwiftLint rule about optional bool (#513)

5b3727d

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

pylapp and others added 18 commits February 5, 2026 12:16

chore: expose for macOS 13 and not 15 at least (#513)

5b25e5c

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

chore: remove dead code (#513)

4271e8e

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

docs: add illustrations in theme catalogs (#513)

72ec981

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

chore: fix typo in doc (#513)

93e9c27

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

chore: fix typos (#513)

6924605

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

fix: use parameters in Item init

66b87ed

fix: adjust width for bullet as text to manage dynamic font and adjus…

d37f4eb

…t maxheight of bullet container to keep it alligned top

fix: update after first design review

06f0095

refactor: improve l10N for arabic (#513)

b8b73f4

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

refactor: vocalization of ordered lsit items (#513)

9bf2894

Acked-by: Pierre-Yves Ayoul <pierre-yves.ayoul@orange.com> Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

refactor: manage arabic language for bullets of ordered lists (#513)

9add7bf

Acked-by: Ahmed Amine Zribi <ahmedamine.zribi@sofrecom.com> Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

chore: clean up (#513)

4b68d34

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

chore: remove useless log

730aa2b

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

refactor: management of arabic alphabet (#513)

aa63f01

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

refactor: use parenthesis for third level of list in arabic (#513)

5deba18

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

test: update etsts for arabic (#513)

5622e19

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

chore: fix typos in docs (#513)

027c0f6

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

docs: update AGENTS.md (#513)

ad3d5d5

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

pylapp force-pushed the 513-component-create-component---bullet-list branch from b3b8cb4 to ad3d5d5 Compare February 5, 2026 11:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#513] Add Bullet List component#1279

[#513] Add Bullet List component#1279
ludovic35 wants to merge 31 commits intodevelopfrom
513-component-create-component---bullet-list

ludovic35 commented Jan 28, 2026 •

edited by pylapp

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pylapp left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ludovic35 commented Jan 28, 2026 • edited by pylapp Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues

Description

Motivation & Context

Types of change

Previews

Checklist

Contribution

Accessibility

Design

Development

Documentation

Checklist (for Core Team only)

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pylapp left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ludovic35 commented Jan 28, 2026 •

edited by pylapp

Loading