Changes to build for MacOS as non-root in GitHub Actions#56
Merged
Conversation
This makes several changes that allow us to build MacOS projects as non-root, which will be necessary for running in GitHub Actions.
A bit of cleanup to not chown everything
We will now build all MacOS versions on 15, targeting 13, so we only need a single binary for each arch.
Since GitHub actions runners already have brew installed (or we will be installing it ourselves for x86_64 on GHA), don't use the separate 'test' user. We also no longer need this user since we are fixing things to run as non-root.
Since MacOS hasn't been called OSX in quite some time, this changes things to generally use 'macos' in place of 'osx'. Also, we plan on building a single MacOS agent for each architecture, so we'll be using a platform string like macos-all-<arch>.
Add a period between 'macos' and 'all' since we aren't using a number here and 'macosall' looks weird. Also adds the architecture.
01f47d9 to
bedb204
Compare
bastelfreak
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building off the amazing work of @shaun-rutherford-blizzard in #46, this makes the necessary changes to build MacOS projects as non-root (but a user with sudo privs) so that we can build things in GitHub Actions. This also changes the naming of MacOS platform strings from
osx-tomacos-, and since we will be targeting all supported MacOS versions for a given architecture, there are some tweaks to support platforms ofmacos-all-<arch>.