Closed
Conversation
bastelfreak
reviewed
May 14, 2025
.rubocop.yml
Outdated
|
|
||
| AllCops: | ||
| TargetRubyVersion: 3.1 | ||
| TargetRubyVersion: 3.2 |
Contributor
There was a problem hiding this comment.
If we do this, we would need to bump required_ruby_version in the gemspec as well. I never understood why Perforce decided to set ruby 3.1 as lower version but vendor Ruby 3.2 in the AIO.
Member
Author
There was a problem hiding this comment.
Hmm, yeah, I suppose we should.
Member
Author
There was a problem hiding this comment.
Ah, I think it's because JRuby 9.4 only supports 3.1. But 3.1 is EOL so that's why 3.2 is in the AIO. JRuby 10 supports 3.4, but that's a lot more work to get there. I should probably remove the set commit since that might not work with JRuby.
Contributor
There was a problem hiding this comment.
Ah maybe that's why it's pinned to 3.1 :( IMO we should stick to that version until we do a major release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the moment, this continues to shove linting issues under the rug. Will look at pulling them out from under the rug in another PR.