Added code to preserve MissingReference entries when going from OTIO to AAF - #77
Open
danneufeldt wants to merge 1 commit into
Open
Added code to preserve MissingReference entries when going from OTIO to AAF#77danneufeldt wants to merge 1 commit into
danneufeldt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76
The MissingReference in an AAF generated within the Avid corresponds to a TapeMob which in some mysterious way ties to the "physical media" separately from the video that is actually displayed. In my testing, each clip in an Avid generated AAF converted to OTIO contained two references, one ExternalReference and one MissingReference. The missing references are not converted when going back to AAF using otio-aaf-adapter and this causes some issues when loading the timeline into the Avid, at least in the testing done at our facility. I was able to resolve this for us cleanly with the code in this pull request, which just tries to transcribe all the data out of the otio.schema.MissingReference class into the tapemob created in AAFFileTranscriber._unique_tapemob. This PR modifies aaf_writer.py with two utility functions for obtaining the physical source mob from a clip and getting the mob id from a MissingReference, updates _unique_tapemob to construct the tapemob using the information from the MissingReference if available, and updates _TrackTranscriber._create_tapemob to use the range from the tapemob if available when constructing the time range for the tapemob slot segment. No new tests are contributed at this time, once I have permission to share some AAFs created at this facility I plan to add tests specific to this behavior.