Preserving markers on round trip from AAF -> OTIO -> AAF - #75
Open
danneufeldt wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74
Add support for writing markers back into an AAF based on markers in an otio timeline. These markers can originate from an AAF during a round trip operation, or be authored originally using the otio API. This PR adds to aaf_writer.py a marker color lookup dictionary, utility functions for getting an appropriate color from a marker, iterating markers within a track, and computing the position a marker should have on a track, as well as a transcribe_markers function responsible for creating markers in an aaf2.AAFFile based on the markers in an otio timeline. It also modified advanced_authoring_format.py to include calculation of the track and slot numbers needed to bind the markers to clips on the track and calls the transcribe_markers function on the AAFFileTranscriber object. No new tests are added at this time, but I'm hoping to add some after getting permission to contribute AAFs generated at our facility.