Fix wrong hook constants in read transcribe hooks and add read hook test - #73
Open
hasielhassan wants to merge 1 commit into
Open
Fix wrong hook constants in read transcribe hooks and add read hook test#73hasielhassan wants to merge 1 commit into
hasielhassan wants to merge 1 commit into
Conversation
|
|
Signed-off-by: Hasiel Alvarez <hasielhassan@gmail.com>
hasielhassan
force-pushed
the
read_hooks_fix
branch
from
July 9, 2026 06:52
24d46a2 to
c5e3390
Compare
timlehr
approved these changes
Jul 25, 2026
timlehr
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @hasielhassan! That's an embarrassing oversight in my code haha. There is an issue with the CIs using the latest OTIO main, but once that is resolved, I should be able to merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
N/A — found while trying to use the hooks and reviewing the hooks module.
Summarize your change.
run_pre_read_transcribe_hookandrun_post_read_transcribe_hookinhooks.pywere usingHOOK_PRE_WRITE_TRANSCRIBE/HOOK_POST_WRITE_TRANSCRIBEinstead of their READ counterparts. This meant the read hooks would never fire correctly.Changes:
run_pre_read_transcribe_hookotio.hooks.runcall inrun_post_read_transcribe_hooktest_transcribe_hook_args_maptotest_transcribe_write_hook_args_mapfor claritytest_transcribe_read_hook_args_mapto cover the read hook pathReference associated tests.
test_transcribe_read_hook_args_map— new test that validates both pre and post read hooks fire correctly using the existinghooks_plugin_exampleplugintest_transcribe_write_hook_args_map— existing test (renamed), still covers the write pathtest_transcribe_hooks_registry— existing test, unchanged