Skip to content

Update coindesk ToS selector#3840

Merged
clementbiron merged 3 commits intomainfrom
update-coidesk-tos
Apr 28, 2025
Merged

Update coindesk ToS selector#3840
clementbiron merged 3 commits intomainfrom
update-coidesk-tos

Conversation

@Cli4d
Copy link
Copy Markdown
Member

@Cli4d Cli4d commented Apr 28, 2025

I updated Coindesk Terms of Service selectors to reduce cases of blinking in tracking changes. I have not included a history.json file since I am not sure how to get the valid until date, as it is supposed to be the last snapshot time and date, but this service continues its tracking. Maybe you can provide more direction here

@Cli4d Cli4d requested review from MattiSG and clementbiron April 28, 2025 04:37
@clementbiron
Copy link
Copy Markdown
Member

Hi Clifford

Thanks for the pull request, it will be great to fix this blink 👍

I've taken the liberty of improving the selector, although your .flex-grow proposal works, I think it might be less stable because it's a generic class name that could be used repeatedly on non-meaningful content.

I also added the history and to do this I searched in the version history of this document for the commit that preceded the introduction of the blink. I think it's this one OpenTermsArchive/contrib-versions@69d2440
It's an appromixation because the commit contains both the blink and the meaningful change, but it seems acceptable to me.

From that commit, i found the validUntil date by inspecting the Nov 25, 2024 date.
image

@clementbiron clementbiron merged commit 9859fef into main Apr 28, 2025
4 checks passed
@clementbiron clementbiron deleted the update-coidesk-tos branch April 28, 2025 12:32
@Cli4d
Copy link
Copy Markdown
Member Author

Cli4d commented Apr 29, 2025

Hi Clifford

Thanks for the pull request, it will be great to fix this blink 👍

I've taken the liberty of improving the selector, although your .flex-grow proposal works, I think it might be less stable because it's a generic class name that could be used repeatedly on non-meaningful content.

I also added the history and to do this I searched in the version history of this document for the commit that preceded the introduction of the blink. I think it's this one OpenTermsArchive/contrib-versions@69d2440 It's an appromixation because the commit contains both the blink and the meaningful change, but it seems acceptable to me.

From that commit, i found the validUntil date by inspecting the Nov 25, 2024 date. image

Thanks so much for this review @clementbiron. At least it sheds more light on how to best handle blink PRs, and especially getting a valid until date. Thank you

I'll apply this information to any more PRs that I open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants