Add declarations for Honkai Star Rail#3834
Merged
Cli4d merged 4 commits intoOpenTermsArchive:mainfrom Apr 10, 2025
Merged
Conversation
Contributor
Author
|
Sample output from the declaration (tested today): |
Cli4d
requested changes
Apr 10, 2025
Member
Cli4d
left a comment
Cli4d
left a comment
There was a problem hiding this comment.
Hi @HerrBrain
First of all thanks for adding these terms to be tracked. I have reviewed your pull request and it all checks out. However there is a change I would suggest.
- We can change the service ID (also used as the JSON file name) to
Honkai-Star Railbased on our documentation. The name of the service isHonkai: Star Railso the:converts to-
But apart from that it looks good to me ✅. I will make this change and proceed to merge
Member
|
Also as a good practice, it is preferred to have one pull request per contractual document such as terms of service or privacy policy. So that each contractual document is reviewed independently. |
Cli4d
reviewed
Apr 10, 2025
declarations/Honkai Star Rail.json
Outdated
| @@ -0,0 +1,29 @@ | |||
| { | |||
| "name": "Honkai Star Rail", | |||
Member
There was a problem hiding this comment.
Suggested change
| "name": "Honkai Star Rail", | |
| "name": "Honkai: Star Rail", |
We can also maintain the original name of the service as our service name
Cli4d
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a declaration for the game Honkai: Star Rail, tested using the OTA web tool.