Asymmetric trainruns

[louisgreiner]

Description

Feature not perfect, but it's such a rabbit hole I could implement / fix features for a century.

Note

About the consecutive times propagation: I keep the existing code identical since travelTime.consecutiveTime and backwardTravelTime.consecutiveTime are never called. However these might be nice be to refactored. (propagateInitialConsecutiveTimes, propagateTrainrunInitialConsecutiveTimes, propagateConsecutiveTimesForTrainrun, propagateConsecutiveTimes) => TimeLockDto is a bigger than the needs of the travel times

Ref #418

For reviewing: https://sncf.sharepoint.com/:p:/r/sites/OSRD644GrpO365/_layouts/15/Doc.aspx?sourcedoc=%7B68C024EF-2C05-4B4D-86C1-ED205F966F2F%7D&file=Cas%20modifs%20temps%20NGE.pptx&action=edit&mobileredirect=true

Missing documentation / video perhaps

Issues

Some bugs (shaky features) to fix:

• symmetry recalculation on non-stop (only reset symmetry on first or last section currently)
• BackwardTravelTime text position on reticular bugged (inverted sometimes with the travelTime)

Checklist

• This PR contains a description of the changes I'm making
• I've read the Contribution Guidelines
• I've added tests for changes or features I've introduced
• I documented any high-level concepts I'm introducing in documentation/
• CI is currently green and this is ready for review

[aiAdrian]

I try to review it and we have to understand when and how we like to merge.

I see currently three release/merge path:

1. merge just after release of 2.10
2. Integrate it as soon as possible
3. integrate it as soon as possible but disable asym feature to user to avoid unfinished buggy feature

I personally would prefere vraiant 1) - TBD

[louisgreiner]

I agree, I would prefer to merge after the 2.10 release as well. This review might take some time

[louisgreiner]

For the bug symmetry reset I edited:

symmetry recalculation on non-stop (only reset symmetry on first or last section currently)
SOLUTION : can we merge this as a new feature after the first merge?

@aiAdrian @emersion what do you think? It will simplify the review

[louisgreiner]

Edit: I set it to 14px, tell me what you think of this

Note: About the last commit: asymmetry: fix travel times and name overlapping, I'm still hesistating if we should also reduce the font size from 16px to 14px for name and travel times
@aiAdrian @maelysLeratRosso

16px:

14px (I think I prefer this one):

[emersion]

A few comments I've written when I've started reviewing below.

[aiAdrian]

Is this the latest version of the asymmetric train runs feature? If we merge this branch/PR, will asymmetric train runs be enabled, or do we need to test a different branch?

[louisgreiner]

This PR is currently being re-written and cut in smaller parts by @emersion, in order to make the review and integration of this feature easier. Then, this PR should not be merged

[louisgreiner]

But you can test this branch anyway, the behavior should not be so different with @emersion 's implementation