feat(rfc): JSON embedded files#126
Open
crowecawcaw wants to merge 1 commit intoOpenJobDescription:mainlinefrom
Open
feat(rfc): JSON embedded files#126crowecawcaw wants to merge 1 commit intoOpenJobDescription:mainlinefrom
crowecawcaw wants to merge 1 commit intoOpenJobDescription:mainlinefrom
Conversation
Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
leongdl
reviewed
Apr 16, 2026
| the template has been parsed. If the substituted value contains characters that break the | ||
| quoting chosen at serialization time, the worker gets a parse error. | ||
|
|
||
| This issue has caused real bugs: |
leongdl
reviewed
Apr 16, 2026
| data: | ||
| renderer: "{{Param.Renderer}}" | ||
| resolution: ["{{Param.Width}}", "{{Param.Height}}"] | ||
| passes: |
There was a problem hiding this comment.
Can we define a limit to the max depth? Say 2?
leongdl
reviewed
Apr 16, 2026
|
|
||
| The written file `init-data.json` would contain: | ||
|
|
||
| ```json |
There was a problem hiding this comment.
I'd like to know or think about if we add limits. EG: Max number of keys, max length of keys and values.
Thinking about pen test overflow like cases. If we define something reasonable it would be constraint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #124
This is a request for comments about JSON embedded files.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.