Conversation
|
pre-commit.ci autofix |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1932 +/- ##
==========================================
- Coverage 94.62% 91.35% -3.28%
==========================================
Files 206 208 +2
Lines 18285 18306 +21
==========================================
- Hits 17303 16723 -580
- Misses 982 1583 +601
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hannahbaumann
left a comment
There was a problem hiding this comment.
Thanks @IAlibay , this looks good to me! I'm not sure if I saw all the QoL changes you made to the results or units files, so if there's anything particular you would like me to look at, please let me know.
This may make merging into the membrane PR a bit tricky, but that's also not a big problem.
That's a good point, let's aim to merge the membrane PR first. I can deal with the merge conflict here after the fact. |
|
No API break detected ✅ |
Fixes #1918
Move SepTop unit and results files to separate files, along with minor QoL improvements.
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin